dtrentin 60ce1c9d57 feat(15-logging): NLog structured logging — all output through NLog (v0.5 complete)

Phase 15 complete (2 plans):
- 15-01: NLog 5.2.8 + nlog.config (rolling file daily/7d + console); logger fields in
  FanucMachine, HeidenhainMachine, SiemensMachine, MitsubishiMachine, Lsv2Client, Program.cs;
  SetState event handler catches → _log.Warn; cleanup catches annotated; ISS-003/ISS-004 closed
- 15-02: All Console.Write/WriteLine in Program.cs replaced with _log.Info (103 calls);
  nlog.config console target layout=${message}, levels=Info only — Warn/Error file-only;
  operator console output identical; every interaction now timestamped in log file

Milestone v0.5 Operational Quality complete.

Co-Authored-By: Claude <noreply@anthropic.com>

2026-05-18 23:57:27 +02:00

3.7 KiB

Raw Blame History

phase

plan

subsystem

Phase 15 Plan 02: Console → NLog Summary

All 97 Console.Write/WriteLine calls in Program.cs replaced with _log.Info; nlog.config console target reconfigured to plain ${message} layout, Info-only.

Performance

Metric	Value
Duration	~30min
Tasks	2 completed
Files modified	2

Acceptance Criteria Results

Criterion	Status	Notes
AC-1: Console output unchanged for operator	Pass	layout=`${message}`; no level/logger prefix; text identical
AC-2: All operator output recorded in log file	Pass	file rule minlevel="Debug" unchanged; Info calls go to file
AC-3: Warn/Error stay out of operator console	Pass	console rule `levels="Info"` (not minlevel) — Warn/Error file only

Accomplishments

Program.cs: zero Console.Write/Console.WriteLine calls remain
nlog.config: console target layout=${message}, rule levels="Info" (exactly Info only)
Full operator session now timestamped in logs/nc_program_manager.log

Files Created/Modified

File	Change	Purpose
`nlog.config`	Modified	Console target: layout `${message}`, rule `levels="Info"`
`Program.cs`	Modified	97 Console.* calls → _log.Info; 103 _log.Info total; 3 _log.Error unchanged

Decisions Made

Decision	Rationale	Impact
Multi-line Console.WriteLine → 7 _log.Info calls	One call per field is cleaner; log file shows each field on its own timestamped line	_log.Info count 103 vs plan-predicted 98
Console.ReadLine() preserved	Debug pause, not output — out of scope per plan constraints	grep Console. = 1, not 0

Deviations from Plan

Summary

Type	Count	Impact
Auto-fixed	0	—
Scope additions	0	—
Count discrepancy	1	Immaterial

Detail

_log.Info count: 103 vs plan-predicted 98

Plan expected: 97 former WriteLine + 1 merged pair = 98
Actual: multi-line Console.WriteLine("manufacturer: " + ... "\n" + ...) was 1 call but split to 7 _log.Info calls (one per field)
Impact: none; all output correct; count difference is additive not subtractive

grep -c "Console." = 1, not 0

Plan verification regex Console\. matches Console.ReadLine() which must stay (debug pause)
Zero Console.Write / Console.WriteLine remain — plan intent fully met
Plan's verify command was slightly too broad

Issues Encountered

None.

Next Phase Readiness

Ready:

Phase 15 logging complete — both plans done
All operator output through NLog with timestamps
Warn/Error isolated to log file; console clean

Concerns:

None

Blockers:

None — Phase 15 complete; v0.5 milestone complete

Phase: 15-logging, Plan: 02 Completed: 2026-05-18

3.7 KiB Raw Blame History