dtrentin bd17ea46e5 feat(11-refactor): extract ArgParser, fix error handling, remove dead code

Phase 11 complete:
- ArgParser.cs: CLI parsing extracted from Program.cs (pure static method)
- Program.cs: no static state; Scarica/Invia take explicit InputArgs param
- Program.cs: try/finally with connected flag — fixes connection leak on exception
- Program.cs: PrintErrors helper surfaces CncResult.Errors on every failure
- AesCrypt.cs: deleted (dead code, zero references)
- NcProgramManager.csproj: AesCrypt.cs → ArgParser.cs

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-05-18 00:01:32 +02:00

2.7 KiB

Raw Blame History

phase

plan

subsystem

tags

requires

provides

affects

tech-stack

key-files

key-decisions

patterns-established

duration

started

completed

11-refactor

cli

error-handling

refactor

connection-management

phase	provides
11-01	Scarica/Invia with explicit InputArgs parameter — enables this plan's refactor

try/finally disconnect guarantee in Scarica and Invia

PrintErrors helper — surfaces CncResult.Errors on every failure

Connection leak bug fixed (catch block previously had no disconnect)

added

patterns

try/finally with connected flag for resource cleanup after async connect

created

modified

Program.cs

connected flag (bool) preferred over nested try — simpler than tracking state across multiple early returns

PrintErrors prints to stdout before VediErrore — operator sees machine detail then error code

Resource cleanup pattern: bool connected = false; try { ... connected = true; } finally { if (connected) Disconnect(); }

~10min

2026-05-18T00:00:00Z

Phase 11 Plan 02: Scarica/Invia error handling refactor

Fixed connection leak in Scarica/Invia (try/finally with connected flag); CncResult.Errors now printed before every error code.

Performance

Metric	Value
Duration	~10min
Tasks	2 completed
Files modified	1

Acceptance Criteria Results

Criterion	Status	Notes
AC-1: Disconnect always runs after connect	Pass	`finally { if (connected) DisconnectAsync() }` in both methods
AC-2: No manual disconnect inside try	Pass	Zero `DisconnectAsync` calls inside try blocks — verified by grep
AC-3: CncResult errors printed on failure	Pass	`PrintErrors(result.Errors)` called at all 8 CncResult failure sites

Files Created/Modified

File	Change	Purpose
`Program.cs`	Modified	try/finally pattern, `connected` flag, `PrintErrors` helper added

Decisions Made

Decision	Rationale	Impact
`bool connected` flag over nested try	Simpler than inner try; clearly marks connect/disconnect boundary	Easy to read, no double-catch complexity
`PrintErrors` before `VediErrore`	Operator sees machine-level detail first, then summary code	Better diagnostics; no behavior change otherwise

Deviations from Plan

None — plan executed exactly as written.

Next Phase Readiness

Ready:

Phase 11 complete — Program.cs clean, ArgParser isolated, errors surfaced
Phase 12 (docs-cli) can proceed: README needs full CLI param table

Concerns: None.

Blockers: None.

Phase: 11-refactor, Plan: 02 Completed: 2026-05-18

2.7 KiB Raw Blame History