Phase 16 (v0.6 milestone) — supporto Fagor CNC via FTP, riuso pattern Siemens/Mitsubishi (FtpWebRequest + ASCII). Modelli supportati: 8060/8065/8070 (FTP nativo), 8055 (con opzione Ethernet). Modelli 8025-8050 esclusi (solo RS232). Code: - Cnc/Fagor/* — FagorConnectionConfig, IFagorFtpClient, FagorFtpClient, FagorMachine. ProgramExtension configurabile (default .nc), ProgramDirectory /Users/Prg/. - Cnc/Models/CncManufacturer.cs — enum + Fagor. - Cnc/CncMachineFactory.cs — case Fagor, porta default 21. - Cnc/NcProgramValidator.cs — refactor IsRestrictiveDialect(): block-80/no-tab/no-lowercase/nested-parens/comment-32 ora applicati solo a Fanuc+Mitsubishi (Heidenhain/Siemens/Fagor esenti). Fagor name rules: max 24 char, no ñ (escape ñ per safety codepage), stem alphanumerico + spazi (estensione separata). - ArgParser.cs — case "fagor". - Program.cs — help text manufacturer/username/password. Tests: - FagorMachineTests — 12 unit (10 mock + 2 validator reale). - FagorMachineIntegrationTests — 5 stub-based (riusa FtpServerStub) + 1 hardware skip via FAGOR_TEST_IP env var. - NcProgramValidatorTests — 12 nuovi Fagor (8 + 4 extension coverage), 6 lock Siemens/Heidenhain exemption, 3 esistenti Siemens→Fanuc. - CncMachineFactoryTests — Create_Fagor_ReturnsFagorMachine. Docs: - README.md — sezione "Controller Fagor" italiano: modelli supportati/ non supportati, regole nome, env var test. Build: - *.csproj — 4 Compile Include main + 2 test. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
127 lines
3.7 KiB
C#
127 lines
3.7 KiB
C#
using System;
|
|
using NUnit.Framework;
|
|
using NcProgramManager.Cnc;
|
|
using NcProgramManager.Cnc.Fanuc;
|
|
using NcProgramManager.Cnc.Heidenhain;
|
|
using NcProgramManager.Cnc.Mitsubishi;
|
|
using NcProgramManager.Cnc.Models;
|
|
using NcProgramManager.Cnc.Siemens;
|
|
using NcProgramManager.Cnc.Fagor;
|
|
|
|
namespace NcProgramManager.Tests.Unit
|
|
{
|
|
[TestFixture]
|
|
public class CncMachineFactoryTests
|
|
{
|
|
private static T GetRequiredField<T>(object target, string name)
|
|
{
|
|
var f = target.GetType().GetField(name,
|
|
System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Instance)
|
|
?? throw new InvalidOperationException(
|
|
string.Format("Field '{0}' not found on {1}. Field may have been renamed.", name, target.GetType().Name));
|
|
return (T)f.GetValue(target);
|
|
}
|
|
|
|
private InputArgs BaseArgs()
|
|
{
|
|
return new InputArgs
|
|
{
|
|
ip = "192.168.1.1",
|
|
porta = "",
|
|
username = "user",
|
|
password = "pass",
|
|
nodoHssb = -1
|
|
};
|
|
}
|
|
|
|
[Test]
|
|
public void Create_Fanuc_ReturnsFanucMachine()
|
|
{
|
|
var args = BaseArgs();
|
|
args.manufacturer = CncManufacturer.Fanuc;
|
|
|
|
using (var m = CncMachineFactory.Create(args))
|
|
{
|
|
Assert.That(m, Is.InstanceOf<FanucMachine>());
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Create_Heidenhain_ReturnsHeidenhainMachine()
|
|
{
|
|
var args = BaseArgs();
|
|
args.manufacturer = CncManufacturer.Heidenhain;
|
|
|
|
using (var m = CncMachineFactory.Create(args))
|
|
{
|
|
Assert.That(m, Is.InstanceOf<HeidenhainMachine>());
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Create_Siemens_ReturnsSiemensMachine()
|
|
{
|
|
var args = BaseArgs();
|
|
args.manufacturer = CncManufacturer.Siemens;
|
|
|
|
using (var m = CncMachineFactory.Create(args))
|
|
{
|
|
Assert.That(m, Is.InstanceOf<SiemensMachine>());
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Create_Mitsubishi_ReturnsMitsubishiMachine()
|
|
{
|
|
var args = BaseArgs();
|
|
args.manufacturer = CncManufacturer.Mitsubishi;
|
|
|
|
using (var m = CncMachineFactory.Create(args))
|
|
{
|
|
Assert.That(m, Is.InstanceOf<MitsubishiMachine>());
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Create_Fagor_ReturnsFagorMachine()
|
|
{
|
|
var args = BaseArgs();
|
|
args.manufacturer = CncManufacturer.Fagor;
|
|
|
|
using (var m = CncMachineFactory.Create(args))
|
|
{
|
|
Assert.That(m, Is.InstanceOf<FagorMachine>());
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Create_FanucHssbNode_TransportIsHssb()
|
|
{
|
|
var args = BaseArgs();
|
|
args.manufacturer = CncManufacturer.Fanuc;
|
|
args.nodoHssb = 0;
|
|
|
|
using (var m = CncMachineFactory.Create(args) as FanucMachine)
|
|
{
|
|
var config = GetRequiredField<FanucConnectionConfig>(m, "_config");
|
|
|
|
Assert.That(config.Transport, Is.EqualTo(FanucTransport.Hssb));
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public void Create_FanucNoHssb_TransportIsEthernet()
|
|
{
|
|
var args = BaseArgs();
|
|
args.manufacturer = CncManufacturer.Fanuc;
|
|
args.nodoHssb = -1;
|
|
|
|
using (var m = CncMachineFactory.Create(args) as FanucMachine)
|
|
{
|
|
var config = GetRequiredField<FanucConnectionConfig>(m, "_config");
|
|
|
|
Assert.That(config.Transport, Is.EqualTo(FanucTransport.Ethernet));
|
|
}
|
|
}
|
|
}
|
|
}
|